Set the thread name before detaching the thread #2762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkauf
force-pushed
the
set_thread_name
branch
2 times, most recently
from
4faf148
to
ae32669
Compare
mkauf
requested review from
anaudx,
kwiatrox,
rjablonx and
sunkuranganath
as code owners
kwiatrox
previously approved these changes
Jul 22, 2019
|
@kwiatrox I rebased on the current master, now the format is OK. Can you please approve once again, after the tests have run? |
kwiatrox
previously approved these changes
Jul 23, 2019
|
@mrunge You have merged some PRs lately, can you please merge this PR too? It's already approved. |
mkauf
force-pushed
the
set_thread_name
branch
3 times, most recently
from
0bec1c8
to
730ea63
Compare
pthread_setname_np() does not work reliably when a thread has been
created in a detached state. Set the thread name first, and then call
pthread_detach() afterwards (if necessary).
This prevents error messages like this one:
set_thread_name("unixsock conn"): No such process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_setname_np()does not work reliably when a thread has been created in a detached state. Set the thread name first, and then callpthread_detach()afterwards (if necessary).This prevents error messages like this one:
ChangeLog: Fix a race condition when setting thread names