Add GNULIB_DIR to LDFLAGS in configure.ac on Windows #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokkee
reviewed
Jul 31, 2018
| LDFLAGS="" | ||
| if test "x$ac_system" = "xWindows"; then | ||
| # This is exported from build.sh | ||
| LDFLAGS="$LDFLAGS -L${GNULIB_DIR}" |
There was a problem hiding this comment.
This will only be used for the strtok test. LDFLAGS is later reset to SAVE_LDFLAGS. Is that what you want?
There was a problem hiding this comment.
Yes, "-L${GNULIB_DIR}" is added to LDFLAGS in build.sh, so it's saved with the other flags in SAVE_LDFLAGS.
There was a problem hiding this comment.
Ideally we move all of the windows specific stuff out of build.sh into configure.ac, and let configure detect that it's running under cygwin, where gnulib is etc. But I'm fine with this for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on Cygwin, the linker needs to be pointed to the directory with libgnu.dll to build properly.