Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hide errors when creating manpage #3092

Merged
merged 1 commit into from Feb 19, 2019

Conversation

rubenk
Copy link
Contributor

@rubenk rubenk commented Feb 19, 2019

Apparently the default behaviour for pod2man changed at some point and
now it exits with a syntax error instead of exiting successfully with a
section.

Now we do display the syntax issue:
[ruben@localhost collectd]$ make -j
POD2MAN src/collectd.conf.5
src/collectd.conf.pod around line 10361: You forgot a '=back' before '=head2'
POD document had syntax errors at /usr/bin/pod2man line 69.
make: *** [Makefile:9641: src/collectd.conf.5] Error 255

Apparently the default behaviour for pod2man changed at some point and
now it exits with a syntax error instead of exiting successfully with a
<POD ERRORS> section.

Now we do display the syntax issue:
[ruben@localhost collectd]$ make -j
  POD2MAN  src/collectd.conf.5
src/collectd.conf.pod around line 10361: You forgot a '=back' before '=head2'
POD document had syntax errors at /usr/bin/pod2man line 69.
make: *** [Makefile:9641: src/collectd.conf.5] Error 255
@rubenk rubenk added the Maintenance A pull request without immediate user-observable impact label Feb 19, 2019
Copy link
Member

@octo octo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, pod2man was finally fixed then. Thanks for noticing!

@octo octo merged commit 28c2b62 into collectd:master Feb 19, 2019
@rubenk
Copy link
Contributor Author

rubenk commented Feb 20, 2019

Hmm, older versions don't support the --errors flags. --errors=die is the default behaviour in new versions so I'll remove that, and we'll let CI catch the errors on newer platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance A pull request without immediate user-observable impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants