Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cppflags backport #3229

Merged
merged 2 commits into from Jul 24, 2019
Merged

Cppflags backport #3229

merged 2 commits into from Jul 24, 2019

Conversation

mrunge
Copy link
Member

@mrunge mrunge commented Jul 23, 2019

This is a backport of #3207

@mrunge mrunge added the Maintenance A pull request without immediate user-observable impact label Jul 23, 2019
@mrunge
Copy link
Member Author

mrunge commented Jul 23, 2019

It would be nice to be able to merge this.

@mrunge mrunge added the Automerge Labels PRs to be merged by a bot once approved label Jul 23, 2019
ryan-mccabe
ryan-mccabe reviewed Jul 23, 2019
View reviewed changes
Copy link
Contributor

@ryan-mccabe ryan-mccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously correct spelling fix.

@rpv-tomsk
Copy link
Contributor

Why do you use "unlisted change" here?
As this is bugfix, it must me included into new 5.9 release changelog.

@mrunge
Copy link
Member Author

mrunge commented Jul 23, 2019

As in the last backport, I cherry-picked the patches and included the changes in the changelog manually.

Of course, it's debatable how we are doing this. In the past, bugfixes had to go to the stable release first, and octo used to merge them to master from time to time. Indeed, I did this as unlisted change, as I don't want to steal credit from original authors.

@rpv-tomsk
Copy link
Contributor

Indeed, I did this as unlisted change, as I don't want to steal credit from original authors.

Reasonable, I missed such behavior of this mech.

@collectd-bot collectd-bot merged commit facf079 into collectd:collectd-5.9 Jul 24, 2019
@mrunge
Copy link
Member Author

mrunge commented Jul 24, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryan-mccabe ryan-mccabe ryan-mccabe approved these changes

@avivgt avivgt avivgt approved these changes

@rjablonx rjablonx rjablonx approved these changes

Assignees
No one assigned
Labels
Automerge Labels PRs to be merged by a bot once approved Maintenance A pull request without immediate user-observable impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mrunge @rpv-tomsk @ryan-mccabe @avivgt @rjablonx @collectd-bot @dago