Compare both PID and process start time to avoid issues with immediate PID reuse on Linux #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run contrib/format.sh src/processes.c and added commit. |
octo
force-pushed
the
bugfix-negative-cpu
branch
from
d4bbb50
to
9c27599
Compare
|
Hey guys, I cannot merge myself, please merge. |
added 2 commits
November 23, 2023 13:28
…e PID reuse on Linux platform.
octo
force-pushed
the
bugfix-negative-cpu
branch
from
9c27599
to
d47b702
Compare
|
Rebased on |
|
As far as I can see, the build failures are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When PID is reused on Linux between two cycles, the data from the old process will not be cleared and new process will reuse the previous data. This is causing issues like negative CPU.
We have seen those issues at scale in Google Cloud, and this patch fixed the issue completely. This fix is tested at scale for 6 months already.
ChangeLog: processes.c: fix negative CPU reporting caused by PID reuse on Linux.