Fix debug print of excluderegex if NULL #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
excluderegex in logparser plugin is optional, hence can be NULL. If debug is enabled, debug print causes a CRITICAL error log like vfprintf %s NULL in "utils_match: match_create_callback: regex = %s, excluderegex = %s"
kwiatrox
reviewed
Jul 20, 2021
| @@ -204,7 +204,7 @@ match_create_callback(const char *regex, const char *excluderegex, | |||
| int status; | |||
|
|
|||
| DEBUG("utils_match: match_create_callback: regex = %s, excluderegex = %s", | |||
| regex, excluderegex); | |||
| regex, excluderegex != NULL ? excluderegex : ""); | |||
There was a problem hiding this comment.
Personally I would change it to something more meaningful than empty string, which is not visible for the user, like:
excluderegex != NULL ? excluderegex : "NULL" or excluderegex != NULL ? excluderegex : "''".
There was a problem hiding this comment.
I see that in similar cases the collectd source code prints the following:
"(null)"in src/configfile.c"<NULL>"in src/utils_curl_stats.c"(nil)"in src/netlink.c""in src/nginx.c (as in my pr)
Your suggestion would be fine with me, but it will add yet another variation to the list. As you (the collectd contributors) wish.
There was a problem hiding this comment.
So we can choose existing one to not add another variation, I would choose between "(null)" or "<NULL>".
kwiatrox
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: match utility: The printing of a
NULLpointer in debug mode has been fixed.