NUT plugin: fix "port" and "answer_num" to stricter int types… #4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, guess I need to fiddle with |
jimklimov
force-pushed
the
fix/nut-2.8.0
branch
2 times, most recently
from
db5276e
to
c33d95e
Compare
…d against Either use the stricter int types required by NUT headers since v2.8.0 release, or the relaxed (arch-dependent) types required by older NUT releases - depending on which NUT API version the collectd is building against at the moment. Inspired by discussion at networkupstools/nut#1638
jimklimov
force-pushed
the
fix/nut-2.8.0
branch
from
c33d95e
to
4644d14
Compare
jimklimov
changed the title
|
Sorry about the back-and-forth in your CI setup... getting it to complain in the right places at right times (and so detect currently suitable types) took a few iterations :) |
… NUT plugin NOTE: src/nut.c also has pragmas to error out in this situation, but that handling is compiler-dependent and happens too late in the checkout/configure/build loop. Presumably this inability to find the type in the earlier-found header file is also triggered by build environment "inconsistencies" like lack of basic types in the libc implementation (maybe highlighting the need for additional headers or macros for the platform).
mrunge
approved these changes
Sep 6, 2022
|
thanks! |
|
I suppose the recently appearing |
|
The test failures have nothing to do with this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as required by NUT headers since v2.8.0 release (and cater to architecture-dependent int types if building against older NUT releases)
Inspired by discussion at networkupstools/nut#1638 with @ffontaine (maintainer of this plugin, AFAIK?)
This is a quick fix for build errors with "reproducer" set up as documented at: networkupstools/nut#1638 (comment)
ChangeLog: nut plugin: adapted to NUT public API changes in version 2.8.0