[collectd 6] Sysman plugin improvements #4109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in L0 spec v1.3. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Added in L0 spec v1.4. Requires loader 1.8.0 version released in May 2022. (With minor cleanup comments from Alexey applied.) Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
- Move enabled/disabled metric reporting to a separate function - Report metrics enabling and metric details enabling separately - Error if all metrics are disabled, regardless of detail options - Explicitly log what metrics are still being reported if any of them were disabled at run-time Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Fixes: 55a9296 Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
octo
reviewed
Apr 23, 2023
| if (!disabled) { | ||
| INFO("- none"); | ||
| } | ||
| INFO("Enabled metrics:"); |
There was a problem hiding this comment.
Please move this out of this if block. The enabled metrics are printed unconditionally, and so should this line.
There was a problem hiding this comment.
All metrics printing is conditional on config.gpuinfo. But I moved it out, as code is clearer that way.
"none" could be logged erronously when "DisableEngine" is set. Add test code for that (does not validate the log output, but runs that and "no metrics + logging" cases so output can be checked manually). Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
eero-t
force-pushed
the
sysman-improvements
branch
from
322260e
to
55844b8
Compare
mrunge
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: gpu_sysman plugin: Misc improvements
Improvements:
[1] Plugin supports large number of Sysman provided metrics. It tries each metric, logs failure for each missing one, and disables further queries for that. However, it could be hard to determine which metrics are actually enabled in the end, especially for older integrated GPUs which provide data only for couple of metrics.
After this change, plugin will log a list of the enabled (and disabled) metrics at end of query round, if the enabled metric set changed (which should happen only few times at startup).