processes: add contextswitches a configurable option & use buffer to read /proc/stat 's content only once #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
Signed-off-by: tiozhang <zyhtheonly@yeah.net>
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
|
@vincele Thank you! All resolved, please help review again. |
eero-t
reviewed
May 5, 2023
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
vincele
suggested changes
May 5, 2023
vincele
reviewed
May 5, 2023
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
Signed-off-by: tiozhang <zyhtheonly@yeah.net> Signed-off-by: luffysong <zsfz_one@163.com>
vincele
reviewed
May 8, 2023
eero-t
reviewed
May 8, 2023
|
@mrunge review feedback so far has been handled, do you want something still to be done before you merge? |
|
thank you, this looks good to me, and thank you for the effort following up with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: add contextswitches a configurable option & use buffer to read /proc/stat 's content only once
We already have a plugin "contextswitch" to collect "ctxt" in "/proc/stat" in Linux. But since we also read from "/proc/stat" from plugin "processes". We add an option to enable "contextswitch" in plugin "processes", default disabled. For this feature, please see 58a1e09
Also, we find that we open and read "/proc/stat" repeatedly when we read "procs_running" and "fork_rate", so we also patch this by only reading "/proc/stat" once into a buffer and making "procs_running", "fork_rate" and "contextswitch" read from this buffer. For this feature, please see de2d033
Tested on my local Linux machines; please help review. Thanks a lot!