Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intel RDT: fix compilation with libpqos < 4.4. #4154

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

octo
Copy link
Member

@octo octo commented Nov 23, 2023

Currently the compilation fails on a number of systems with the following error:

  CC       src/intel_rdt_la-intel_rdt.lo
../../src/intel_rdt.c: In function 'rdt_config_events':
../../src/intel_rdt.c:49:54: error: 'PQOS_PERF_EVENT_LLC_REF' undeclared (first use in this function); did you mean 'PQOS_PERF_EVENT_LLC_MISS'?
    PQOS_MON_EVENT_TMEM_BW | PQOS_MON_EVENT_RMEM_BW | PQOS_PERF_EVENT_LLC_REF)
                                                      ^~~~~~~~~~~~~~~~~~~~~~~
../../src/intel_rdt.c:568:13: note: in expansion of macro 'RDT_EVENTS'
   events &= RDT_EVENTS;
             ^~~~~~~~~~
../../src/intel_rdt.c:49:54: note: each undeclared identifier is reported only once for each function it appears in
    PQOS_MON_EVENT_TMEM_BW | PQOS_MON_EVENT_RMEM_BW | PQOS_PERF_EVENT_LLC_REF)
                                                      ^~~~~~~~~~~~~~~~~~~~~~~
../../src/intel_rdt.c:568:13: note: in expansion of macro 'RDT_EVENTS'
   events &= RDT_EVENTS;
             ^~~~~~~~~~
make[2]: *** [Makefile:8133: src/intel_rdt_la-intel_rdt.lo] Error 1

ChangeLog: Intel RDT plugin: A compatibility issue with pqos < 4.4 has been fixed.

@octo octo requested a review from a team as a code owner November 23, 2023 13:21
@octo octo force-pushed the intel_rdt branch 3 times, most recently from 43e4b25 to 609a437 Compare November 23, 2023 14:40
@octo octo added the build An issue with the build label Nov 23, 2023
@octo octo merged commit 4b3788f into collectd:main Nov 23, 2023
20 of 25 checks passed
@octo octo deleted the intel_rdt branch November 23, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue with the build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant