Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_log plugin: remove the "write_log values:" line when logging metrics. #4175

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

octo
Copy link
Member

@octo octo commented Nov 29, 2023

These lines use up vertical screen real estate and don't provide utility.

See discussion in #4173

ChangeLog: write_log plugin: extra output lines have been removed to streamline output.

@octo octo requested a review from a team as a code owner November 29, 2023 09:56
@collectd-bot collectd-bot added this to the 6.0 milestone Nov 29, 2023
@eero-t
Copy link
Contributor

eero-t commented Nov 29, 2023

Similar change to main branch would be nice, but maybe it's better to collect all changes in v6 branch first and then synch them to main.

@octo
Copy link
Member Author

octo commented Nov 29, 2023

I'll can cherry-pick to main after merging.

@eero-t By the way, I sent you an invite to join the "Trusted Contributors" group that would allow you to approve PRs like this one.

@octo octo merged commit 9e2c46a into collectd:collectd-6.0 Nov 29, 2023
21 of 26 checks passed
@octo
Copy link
Member Author

octo commented Nov 29, 2023

Cherry pick is in eb728bd

@octo octo deleted the write_log6 branch December 5, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants