Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[collectd 6] memory plugin: Align metrics with OpenTelemetry recommendations. #4219

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[collectd 6] memory plugin: Align metrics with OpenTelemetry recommendations. #4219

merged 1 commit into from
Jan 3, 2024

Conversation

octo
Copy link
Member

@octo octo commented Dec 29, 2023

  • The "state" label has been renamed to "system.memory.state".
  • Metric descriptions and units have been added.

ChangeLog: Memory plugin: The metric schema has been aligned with OpenTelemetry semantic conventions.

@octo octo requested a review from a team as a code owner December 29, 2023 15:26
@collectd-bot collectd-bot added this to the 6.0 milestone Dec 29, 2023
@octo octo added this to In progress in collectd 6 via automation Dec 29, 2023
@octo octo mentioned this pull request Dec 29, 2023
Closed
eero-t
eero-t approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but it maybe better to merge changes from main first, as v5 and v6 versions have diverged.

@eero-t
Copy link
Contributor

eero-t commented Jan 3, 2024

Looks fine, but it maybe better to merge changes from main first, as v5 and v6 versions have diverged.

Ahem, Leonard already merged memory plugin changes from main year ago (in PR #4076) i.e. memory plugin is already up to date as last commit in main is from Feb 2022 => merging further changes to it is fine.

PS. @octo You already created table of changes between plugins in different branches. Would it make sense to have separate ticket with that table, tracking plugins having changes that still need to be synced from main to v6, which would be updated updated whenever changes have been checked and synced?

@octo octo modified the milestones: 6.0, 6 MVP Jan 3, 2024
@octo octo changed the title memory plugin: Align metrics with OpenTelemetry recommendations. [collectd 6] memory plugin: Align metrics with OpenTelemetry recommendations. Jan 3, 2024
@octo
memory plugin: Align metrics with OpenTelemetry recommendations.
4616f83 
* The "state" label has been renamed to "system.memory.state".
* Metric descriptions and units have been added.
@octo octo merged commit e7dab5c into collectd:collectd-6.0 Jan 3, 2024
24 checks passed
collectd 6 automation moved this from In progress to Done Jan 3, 2024
@octo octo deleted the 6/memory branch January 3, 2024 17:58
@octo octo added the Feature label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eero-t eero-t eero-t approved these changes

Assignees
No one assigned
Labels
Feature
Projects
collectd 6
  
Done
Milestone
6 MVP
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@octo @eero-t @collectd-bot