write_prometheus plugin: Use the unit field to create metric names.
#4220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eero-t
reviewed
Dec 29, 2023
Comment on lines
+77
to
+80
| .name = "system.processes.created", | ||
| .type = METRIC_TYPE_COUNTER, | ||
| .want = "system_processes_created_total", | ||
| }, |
There was a problem hiding this comment.
Btw. _created suffix has special meaning in OpenMetrics and Prometheus clients, see:
There was a problem hiding this comment.
I didn't think about this too much to be honest. I simply grabbed the table from https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/pkg/translator/prometheus and implemented it. I think it's a good start to iterate from.
I don't know how common it is for metric names to end in _created. If this is a problem, I'm sure we can deal with it when it pops up.
|
Sounds reasonable. Items could be left unresolved as reminders, or you can resolve them if you do not think that necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/#metric-metadata-1
ChangeLog: Write Prometheus plugin: Units are appended to metric family names if available.