gpu_sysman: enable plugin automatically when pkg-config finds level-zero dependency
#4239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And enable Sysman plugin automatically when dependency is found. While GPU plugin uses just Sysman API subset of the Level-Zero API family, name of the used library / loader is level-zero => dropped "--with-sysman" option and renamed configure variables. Also, now that Level-Zero packages are in the distributions, Sysman API GPU plugin could be enabled by default when pkg-config finds level-zero. This simplifies config code. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChangeLog: Build system: Automatically enable the gpu_sysman plugin when
level-zerois available.While GPU plugin uses just Sysman API subset of the Level-Zero API family, name of the used library / loader is
level-zero=> renamed configure variables for the dependency to use level-zero/LEVEL_ZERO names.Now that Level-Zero packages are in the distributions, I thought Sysman API GPU plugin can be enabled by default when
pkg-configfindslevel-zero. I did not think it that useful for user to be able to specifylevel-zeropath with a configure option instead of suitablePKG_CONFIG_PATHenv variable => dropped--with-sysmanoption.(There was no good example of doing that in addition to using
pkg-configin reasonable amount of configure.ac code.)PS. Sysman plugin test does much more thorough checking than other tests, so running it takes >10x more time than the other tests.