Test and clean #728
Merged
Test and clean #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove some superfluous parenthesis clutter - Shorten a lot of single-line conditionals using postfix constructions - Merge variable declarations - Use $class/$self instead of $pkg/$obj as is customary - Remove quotes around literal hash keys
Rationale: A frequent use case for LISTVAL is to retrieve a list of resources for a certain host or host group that is not known in advance, such as when the hosts have different disks installed. Using the existing listval() method, Collectd::Unixsock retrieves the entire list, parses each entry into a hash and returns the list, only to have the caller throw away the vast majority of entries immediately. listval_filter() allows the caller to pass any attribute that can be passed to getval() and filters the list of resources retrieved from the socket before parsing it, resulting in a large speedup. The current implemntation has some code duplication, although listval() could be implemented as a small wrapper around listval_filter() with just a few percent speed penalty due to the extra dynamically built regexp.
|
This certainly looks like fine work to me, thanks! |
|
Thanks a lot @mbethke ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use collectd on CentOS which has Regexp::Common available only via the EPEL repo, deprecated at $WORKPLACE due to its rather mixed code quality. Thus I replaced Regexp::Common by the core module Scalar::Util, and while I was at it improved a few more things: