🚀 perf(left/right): Garbage collect empty subcollections.

collection-abstraction · Sep 1, 2020 · 945d903 · 945d903
1 parent 6492d0f
commit 945d903
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/BasePairs.js b/src/BasePairs.js
@@ -48,7 +48,7 @@ export default class BasePairs {
 	}
 
 	left() {
-		return filter((x) => this._map.get(x).size > 0, this._map.keys());
+		return this._map.keys();
 	}
 
 	right() {

diff --git a/src/EfficientlyInvertiblePairs.js b/src/EfficientlyInvertiblePairs.js
@@ -1,4 +1,3 @@
-import {filter} from '@aureooms/js-itertools';
 import BasePairs from './BasePairs';
 import insert from './insert';
 import remove from './remove';
@@ -45,7 +44,7 @@ export default class EfficientlyInvertiblePairs extends BasePairs {
 	// Custom
 
 	right() {
-		return filter((x) => this._imap.get(x).size > 0, this._imap.keys());
+		return this._imap.keys();
 	}
 
 	*leftOf(B) {

diff --git a/src/remove.js b/src/remove.js
@@ -1,6 +1,10 @@
 export default function remove(map, A, B) {
 	if (map.has(A)) {
-		return map.get(A).delete(B);
+		const right = map.get(A);
+		if (right.delete(B)) {
+			if (right.size === 0) map.delete(A);
+			return true;
+		}
 	}
 
 	return false;