Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump mapper version to fix zeitwerk problem #170

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Conversation

kspurgin
Copy link
Contributor

@kspurgin kspurgin commented Jun 7, 2022

  • eager load collectionspace-mapper to pass zeitwerk:check (as per statement from zeitwerk maintainer)
  • Initialize CollectionSpace::Mapper::DataHandler with a client-less RefCache
  • Add csid_cache parameter to constructor for CollectionSpace::Mapper::DataHandler -- Since the only way to search for relations is by subject/object CSID, we need a way to efficiently look up CSIDs. Since I'm already setting up collectionspace-mapper to work with two separate CollectionSpace::RefCache instances for migration tooling stuff---one for refnames for terms, and one for CSIDs---it is much more straightforward to just make it always use two separate RefCaches for these two separate types of information. When CollectionSpace::Mapper is used with the default batch config by collectionspace-csv-importer, the CSID RefCache will only be used for looking up CSIDs to use in constructing searches for relations (required to determine the status of a given relation in the system).

@mark-cooper mark-cooper merged commit 19b94c9 into master Jun 23, 2022
@mark-cooper mark-cooper deleted the migration-tooling branch June 23, 2022 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants