Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add information about sent emails to newsletter issue #156

Merged
merged 22 commits into from Mar 8, 2020
Merged

Add information about sent emails to newsletter issue #156

merged 22 commits into from Mar 8, 2020

Conversation

thomasmassmann
Copy link
Member

See #154 for details.

@thomasmassmann
Copy link
Member Author

@MrTango the travis tests fail with some apt-get errors which I didn't touch at all. Can you please take a look at this?

@thomasmassmann
Move IReceiversPostSendingFilter to send view to filter all recipients.
1d11c4d 
Before only Plone users were filtered.
@thomasmassmann
Add get_keys and fix get_records.
4e905a1
@thomasmassmann
Add IReceiversPostSendingFilter subscriber to filter already sent ema…
9f355fe 
…ils.
@thomasmassmann
Run IReceiversPostSendingFilter subscriber for newsletter context too.
ebdc9b4
@thomasmassmann
Clear send status items when newsletter issue is transitioned into dr…
667370d 
…aft or master.
@thomasmassmann
Only reset when transitioning into master state.
50fe98f 
We will have a dedicated reset.
@thomasmassmann
Don't fail if adapter is not available.
73482e6
@thomasmassmann
Add statistics page.
a13abe7
@thomasmassmann
Add new action for pointing to statistics page.
9c7063d
@thomasmassmann
Add GS upgrade step.
687cad3
@thomasmassmann
Show statistics for drafts as well.
b9b9d51
@thomasmassmann
Use stable chrome for travisci.
53f373d
@thomasmassmann
Try apt update before installing addons.
ae26589
@thomasmassmann
Only install firefox-geckodriver with apt.
3023841
@coveralls
Copy link

coveralls commented Mar 5, 2020 •
edited

Coverage Status

Coverage decreased (-0.1%) to 86.704% when pulling c156c9a on 154-sent-emails-information into aa41356 on master.

MrTango
MrTango requested changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM as discussed, but to merge it, i would like to have at least some tests for the functionality.

@MrTango MrTango marked this pull request as ready for review March 6, 2020 13:09
@MrTango MrTango merged commit 8d5edf8 into master Mar 8, 2020
@MrTango MrTango deleted the 154-sent-emails-information branch March 8, 2020 16:41
@MrTango
Copy link
Contributor

MrTango commented Mar 8, 2020

released as 5.0.0b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrTango MrTango Awaiting requested review from MrTango

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thomasmassmann @coveralls @MrTango