Merge pull request #16 from collective/fix-15

Fix the memcached manager edit form
collective · Mar 18, 2021 · c768b55 · c768b55
2 parents 9b13fcc + 39aa8a7
commit c768b55
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,10 +1,12 @@
 Changelog
 =========
 
-1.3 (unreleased)
-----------------
+1.2.1 (unreleased)
+------------------
 
-- Nothing changed yet.
+- Editing the memcached manager properties through the web results
+  in storing values with the proper data type. (#15)
+  [ale-rt]
 
 
 1.2 (2021-01-04)

diff --git a/Products/MemcachedManager/MemcachedManager.py b/Products/MemcachedManager/MemcachedManager.py
@@ -455,8 +455,7 @@ def manage_editProps(self, title, settings=None, REQUEST=None):
         if settings is None:
             settings = REQUEST
         self.title = safe_nativestring(title)
-        request_vars = list(settings["request_vars"])
-        request_vars.sort()
+        request_vars = sorted(safe_nativestring(r) for r in settings["request_vars"])
         servers = [safe_nativestring(s) for s in list(settings["servers"]) if s]
         mirrors = [safe_nativestring(m) for m in list(settings.get("mirrors", [])) if m]
         debug = int(settings.get("debug", 0))

diff --git a/setup.py b/setup.py
@@ -3,7 +3,7 @@
 from setuptools import setup
 
 
-version = "1.3.dev0"
+version = "1.2.1.dev0"
 description = "Memcached cache manager for Zope."
 long_description = open("README.rst").read() + "\n" + open("CHANGES.rst").read()