fixed workflows

collective · Apr 12, 2013 · 335e2c5 · 335e2c5
1 parent 5d716f8
commit 335e2c5
Show file tree

Hide file tree

Showing 5 changed files with 98 additions and 24 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -7,6 +7,11 @@ Changelog for Poi
 
 - Updated italian translation
   [keul]
+- Now supporting the "Site Administrator" role
+  [keul]
+- Fix tracker security; issues inside private folder
+  must not be visible to anonymous users
+  [keul]
 
 2.2.2 (2013-04-04)
 ------------------

diff --git a/Products/Poi/profiles.zcml b/Products/Poi/profiles.zcml
@@ -111,4 +111,12 @@
       handler="Products.Poi.migration.migrate_tracker_watchers"
       profile="Products.Poi:default" />
 
+  <gs:upgradeStep
+      title="Run workflow import step"
+      description="Updating workflow to reflect changes"
+      source="2005"
+      destination="2006"
+      handler="Products.Poi.migration.run_workflow_step"
+      profile="Products.Poi:default" />
+
 </configure>
diff --git a/Products/Poi/profiles/default/metadata.xml b/Products/Poi/profiles/default/metadata.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <metadata>
-  <version>2005</version>
+  <version>2006</version>
   <dependencies>
     <dependency>profile-Products.AddRemoveWidget:default</dependency>
     <dependency>profile-Products.DataGridField:default</dependency>

diff --git a/Products/Poi/profiles/default/workflows/poi_issue_workflow/definition.xml b/Products/Poi/profiles/default/workflows/poi_issue_workflow/definition.xml
@@ -7,18 +7,21 @@
   <exit-transition transition_id="open-closed"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -28,17 +31,20 @@
   <exit-transition transition_id="postpone"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -74,17 +80,20 @@
   <exit-transition transition_id="reject-open"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -94,17 +103,20 @@
   <exit-transition transition_id="open-postponed"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -113,17 +125,20 @@
   <exit-transition transition_id="open-rejected"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -133,18 +148,21 @@
   <exit-transition transition_id="confirm-resolved"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -156,17 +174,20 @@
   <exit-transition transition_id="resolve-unconfirmed"/>
   <permission-map name="Delete objects" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Modify portal content" acquired="True">
    <permission-role>Manager</permission-role>
    <permission-role>Owner</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
   <permission-map name="Poi: Modify issue state" acquired="False">
    <permission-role>Manager</permission-role>
+   <permission-role>Site Administrator</permission-role>
    <permission-role>Technician</permission-role>
    <permission-role>TrackerManager</permission-role>
   </permission-map>
@@ -276,7 +297,7 @@
  <variable variable_id="action" for_catalog="False" for_status="True" update_always="True">
   <description>The last transition</description>
   <default>
-
+   
    <expression>transition/getId|nothing</expression>
   </default>
   <guard>
@@ -285,7 +306,7 @@
  <variable variable_id="actor" for_catalog="False" for_status="True" update_always="True">
   <description>The ID of the user who performed the last transition</description>
   <default>
-
+   
    <expression>user/getId</expression>
   </default>
   <guard>
@@ -294,7 +315,7 @@
  <variable variable_id="comments" for_catalog="False" for_status="True" update_always="True">
   <description>Comments about the last transition</description>
   <default>
-
+   
    <expression>python:state_change.kwargs.get('comment', '')</expression>
   </default>
   <guard>
@@ -303,7 +324,7 @@
  <variable variable_id="review_history" for_catalog="False" for_status="False" update_always="False">
   <description>Provides access to workflow history</description>
   <default>
-
+   
    <expression>state_change/getHistory</expression>
   </default>
   <guard>
@@ -314,7 +335,7 @@
  <variable variable_id="time" for_catalog="False" for_status="True" update_always="True">
   <description>Time of the last transition</description>
   <default>
-
+   
    <expression>state_change/getDateTime</expression>
   </default>
   <guard>