Fix like/dislike inline popup text translations for composed language… #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
requested changes
Jun 15, 2018
| @@ -96,16 +96,14 @@ def __call__(self, REQUEST, RESPONSE): | |||
|
|
|||
| # Create handy translate function | |||
| translate = self._get_translator() | |||
| ltool = getToolByName(self, 'portal_languages') | |||
There was a problem hiding this comment.
you forgot to remove the import of getToolByName at the top of this file.
… domains like nl-be. Don't try to figure out the preferred_language, but pass the request as the translation context to the translate function.
fredvd
force-pushed
the
fix_popup_translation_function
branch
from
dc21220
to
740f298
Compare
hvelarde
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… domains like nl-be.
Don't try to figure out the preferred_language, but pass the request as the translation context to the translate function.