Prepare for Python 2 / 3 compatibility #23
Conversation
… add Plone 5.1 to the Plone versions in setup.py.
|
@gforcada thanks for the hints. I changed this with my last commit, but the test with travis-ci didn't work further. There seemed to be an issue with the bootstrap.py and setuptools. |
|
I would strongly suggest to move to pip to install setuptools and zc.buildout You might copy the Travis setup from other plone packages, like plone.restapi for example |
| @@ -1,5 +1,11 @@ | |||
| [buildout] | |||
| extends = | |||
| https://raw.githubusercontent.com/collective/buildout.plonetest/master/travis-4.x.cfg | |||
There was a problem hiding this comment.
Seems that without this line, there is 4.3.x.cfg as well as 5.1.x.cfg and 5.2.x.cfg there is no test part being installed and thus tests can not run 😅
Doing a sed replacement here as well for this line would be my suggested change.
… the plone-cfg file and remove the test section from base.cfg.
|
@gforcada there is an issue with the version of cioppino.twothumbs that is used for the instance / test. It uses version 2.1.1 and not 2.1.2-dev from github.com. Is there a suggestion how I could fix this? In my local environment I pinned the repository in the versions section of my local.cfg. |
|
@andreasma you are probably missing |
This reverts commit ff856f3 Currently is Python 3.7 not available for build on travis-ci.
|
@andreasma congrats!! 🎉 would you like to get it released, or are you planning to add more changes? 🤔 |
|
@gforcada thanks for your great support! I'm currently not planning further changes. I removed only the travis entry for building of Plone 5.0. It'd be great if you could merge that change too. |
|
@andreasma 2.1.2 is out, give it a try and report any problem with it 😉 |
No description provided.