Fix exception when related items is broken (#32)

* Fix exception when item don't have related items * Fix changelog
collective · Oct 11, 2016 · b84c4d4 · b84c4d4
1 parent 0fd0af4
commit b84c4d4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -6,6 +6,9 @@ There's a frood who really knows where his towel is.
 1.0a3 (unreleased)
 ------------------
 
+- Avoid exception when related items relation is broken.
+  [rodfersou]
+
 - Fix loading order for main AMP script.
   [hvelarde]
 

diff --git a/src/collective/behavior/amp/browser/__init__.py b/src/collective/behavior/amp/browser/__init__.py
@@ -280,6 +280,10 @@ def relations2brains(self, relations):
         catalog = api.portal.get_tool('portal_catalog')
         brains = []
         for item in relations:
+            # Skip broken relations (deleted content)
+            # https://github.com/plone/plone.app.relationfield/issues/10
+            if item.isBroken():
+                continue
             path = item.to_path
             # the query will return an empty list if the user has no
             # permission to see the target object