Implement validation using Cloudflare's AMP linter API endpoint #59
Conversation
|
@ale-rt are you using AMP? do you want to help reviewing this? @kakshay21 this is what I was expecting just as a beginning. |
hvelarde
force-pushed
the
hvelarde-validation
branch
from
e4b0da5
to
59a89c7
Compare
|
@hvelarde I am interested in the project but unluckily I had no chance to use it and inspect the code in detail. |
| """Validate @@amp view using Cloudflare's AMP linter API endpoint.""" | ||
| request = obj.REQUEST | ||
|
|
||
| if event.status['review_state'] not in ('published', ): |
There was a problem hiding this comment.
if event.status['review_state'] != 'published':
| return | ||
|
|
||
| # remove the scheme from the URL | ||
| url = ''.join(urlparse(obj.absolute_url())[1:]) |
There was a problem hiding this comment.
url = obj.absolute_url() # http://site/myobject
url_no_scheme = ''.join(urlparse(url))[1:] # site/myobject
| # remove the scheme from the URL | ||
| url = ''.join(urlparse(obj.absolute_url())[1:]) | ||
|
|
||
| r = requests.get('https://amp.cloudflare.com/q/' + url + '/@@amp') |
There was a problem hiding this comment.
r = requests.get('https://amp.cloudflare.com/q/{}/@@amp'.format(url_no_scheme))
hvelarde
dismissed
rodfersou’s stale review
I have finished 1 of the 7 things needed here; a review at this point is useless.
| logger.info(msg) | ||
| api.portal.show_message(message=msg, request=request, type='info') | ||
| else: | ||
| msg = u'Not a valid AMP page' |
There was a problem hiding this comment.
Why not include the error in the warning message?
for error in validation['errors']:
msg = msg + str(error)
There was a problem hiding this comment.
Okay, I get it it would be difficult in writing the test case then right? @hvelarde
WIP
closes #16