Add a module global COLLECTIONISH_TARGETS #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensens
force-pushed
the
collectionish-tile-targets
branch
3 times, most recently
from
c7e5d09
to
72413c5
Compare
petschki
force-pushed
the
collectionish-tile-targets
branch
from
95d3e03
to
e237998
Compare
|
I think its because of the pinned |
jensens
force-pushed
the
collectionish-tile-targets
branch
from
6d161c1
to
f48c371
Compare
jensens
force-pushed
the
collectionish-tile-targets
branch
from
f48c371
to
b8b4fb8
Compare
|
All Systems Red. (btw a good scifi read by Martha Wells) sigh here ;-) |
|
strangely also the merge commit from yesterday turned red although the PR was green 🧐 ... somehow the |
petschki
requested changes
Mar 25, 2022
| @@ -213,6 +217,9 @@ def get_filter_items( | |||
| or filter_value in value_blacklist | |||
| ): | |||
| continue | |||
| if isinstance(filter_value, int): | |||
There was a problem hiding this comment.
This breaks boolean filter_value because isinstance(<False or True>, int) == True and therefore boolean values get converted to strings
There was a problem hiding this comment.
There was a problem hiding this comment.
I fixed that ... and portlets too with the new reverse setting
petschki
force-pushed
the
collectionish-tile-targets
branch
from
5640216
to
22112cc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to register other tiles with collections than plone.app.standardtiles.contentlisting
Also: Support Plone 6