Python 3 fixes and tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petschki
commented
Mar 21, 2019
Closed
thet
requested changes
Mar 22, 2019
There was a problem hiding this comment.
Apart from two change requests this LGTM!
- Please check my comment in filtercomments.py
- Please remove the 5.0 compatibility introduced here and keep what is useful (e.g. we don't need to check for 5.0 anymore, but letting portlets derive from
base.AddFormis cool).
Make compatible with 5.0.x #25
I released a 2.1 version and rebased your changes on top of that. Since we got 5.0 support, which is removed with this PR, this will become a 3.0 release.
thet
approved these changes
Mar 22, 2019
|
awesome work, thanx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.