Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper "all" count when "Narrow down filter options" is enabled ( fixes #42 ) #52

Merged
merged 9 commits into from Apr 29, 2019

Conversation

pigeonflight
Copy link
Member

No description provided.

@pigeonflight pigeonflight changed the title True "all" count when "Narrow down filter options" is enabled fixes #42 Proper "all" count when "Narrow down filter options" is enabled fixes #42 Apr 25, 2019
@pigeonflight pigeonflight requested a review from thet April 25, 2019 11:42
@pigeonflight pigeonflight mentioned this pull request Apr 25, 2019
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me. Just tried it out ...

Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can enhance the tests to check if the filter options are really narrowed down?

@pigeonflight
Copy link
Member Author

I've updated the tests to check for narrowing of results.

@pigeonflight pigeonflight changed the title Proper "all" count when "Narrow down filter options" is enabled fixes #42 Proper "all" count when "Narrow down filter options" is enabled (fixes #42) Apr 26, 2019
@pigeonflight pigeonflight changed the title Proper "all" count when "Narrow down filter options" is enabled (fixes #42) Proper "all" count when "Narrow down filter options" is enabled ( fixes #42 ) Apr 26, 2019
add dependencies for robot tests and add a portlet filter robot test
and remove obsolete checkouts. all packages are released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants