Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix broken tests where 5.2 not longer accepts queries with operators no supported by index type #66

Merged
merged 12 commits into from Jul 18, 2019
Merged

fix broken tests where 5.2 not longer accepts queries with operators no supported by index type #66

merged 12 commits into from Jul 18, 2019

Conversation

djay
Copy link
Member

@djay djay commented Jul 9, 2019 •
edited

and Tests for "and" filter type
and also fix a unicode bug with utf/unicode in the batch urls

@djay djay requested a review from thet July 10, 2019 09:55
@djay djay changed the title Tests for "and" filter type fix broken tests where 5.2 no longer accepts queries with operators no supported by index type (and Tests for "and" filter type) Jul 18, 2019
@djay djay changed the title fix broken tests where 5.2 no longer accepts queries with operators no supported by index type (and Tests for "and" filter type) fix broken tests where 5.2 no longer accepts queries with operators no supported by index type Jul 18, 2019
@djay djay changed the title fix broken tests where 5.2 no longer accepts queries with operators no supported by index type fix broken tests where 5.2 not longer accepts queries with operators no supported by index type Jul 18, 2019
@djay djay requested a review from petschki July 18, 2019 05:36
@djay
Copy link
Member Author

djay commented Jul 18, 2019

@thet @petschki Please merge this one first as it fixes the bug with 5.2 which is blocking all the rest of the tests from working.
If you can get to it soon it would make our life a lot less complicated with these multiple PRs building up.

petschki
petschki approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petschki petschki merged commit 0a0d736 into master Jul 18, 2019
@petschki petschki deleted the djay/fix_None_in_filter branch July 18, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petschki petschki petschki approved these changes

@thet thet Awaiting requested review from thet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djay @petschki