Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate filters when displaying multiple filters on a single page #84

Merged
merged 3 commits into from Aug 27, 2019

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Aug 21, 2019

Fixes #83

@JeffersonBledsoe JeffersonBledsoe changed the title Fix duplicate multiple filters. Fixes #83 Fix duplicate multiple filters Aug 21, 2019
@JeffersonBledsoe JeffersonBledsoe changed the title Fix duplicate multiple filters Fix duplicate filters when displaying multiple filters on a single page Aug 21, 2019
@JeffersonBledsoe JeffersonBledsoe marked this pull request as ready for review August 21, 2019 14:39
@djay
Copy link
Member

djay commented Aug 22, 2019

@petschki sorry for the regression. My misunderstanding about view.memoize.

@JeffersonBledsoe JeffersonBledsoe self-assigned this Aug 22, 2019
@petschki
Copy link
Member

I‘m sorry. On vacation 'til mid Sept ... maybe @agitator wants to review...

@JeffersonBledsoe JeffersonBledsoe requested review from agitator and removed request for petschki August 27, 2019 07:33
@thet thet merged commit 581caf9 into master Aug 27, 2019
@thet thet deleted the jeff/display-multiple-filters-test branch August 27, 2019 09:06
@thet
Copy link
Member

thet commented Aug 27, 2019

@JeffersonBledsoe tnx for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate filters when using multiple filters on a single page
4 participants