Customize search button and placeholder #94
Draft
+50
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djay
requested changes
Nov 25, 2019
|
@nngu6036 not all my requests have been fixed and the tests still not passing. |
djay
reviewed
Jan 8, 2020
|
I suspect it's going to work better if we use "leave blank for default 'search'" as that will allow the portlet to work in multiple languages at once. What do you think @petschki ? |
djay
requested changes
Jun 30, 2021
| @@ -38,3 +38,9 @@ Scenario: Searching through a portlet with ajax disabled | |||
| # and should be 4 filter options | |||
|
|
|||
|
|
|||
| Scenario: Customize search porlet text with ajax disabled | |||
There was a problem hiding this comment.
needs to be rebased against the testing branch. There aren't tests specific to portlets anymore. The same test should work for tiles and portlets
| <tal:urlquery repeat="item python:view.urlquery"> | ||
| <input type="hidden" name="${python:item[0]}" value="${python:item[1]}"/> | ||
| </tal:urlquery> | ||
| <input name="SearchableText" type="text" | ||
| placeholder="Search" | ||
| placeholder="${view/settings/placeholder}" |
| ), | ||
| description=_("help_header", u"Placeholder of the search input."), | ||
| required=False, | ||
| default=_(u"Search"), |
There was a problem hiding this comment.
Should have no default so the default will be translated based on the language of the site.
Same as the button text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.