Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3 #62

Open
vernans opened this issue Apr 14, 2019 · 8 comments
Open

Add support for Python 3 #62

vernans opened this issue Apr 14, 2019 · 8 comments
Assignees

Comments

@vernans
Copy link

vernans commented Apr 14, 2019

I'm working on that on PLOG.

@vernans vernans self-assigned this Apr 14, 2019
@vernans
Copy link
Author

vernans commented Apr 17, 2019

@agitator What's up with the plone5 and the plone5degrok branches? Were they just not finished, have there been any problems?

@agitator
Copy link
Member

plone5degrok was an intermediate branch and can be deleted.
plone5 is what I'm using for a client site with 5.1.5
@tdesvenain imho rebased plone5 with master, best thing would be to ask him ;-)

@agitator agitator self-assigned this Jan 14, 2020
@agitator
Copy link
Member

I started working on this in https://github.com/collective/collective.contact.core/tree/plone5-only

@vernans any idea on #61 ?

@agitator
Copy link
Member

Removed all grok remains in plone5-only ...

c.contact.widget would be next to degrok but as I got a better in depth view of the whole addon, I'd rather switch to z3c.relationfield/RelationChoice/RelationList with pat-relateditems than to upgrade and maintain the existing widget package.

UI and functionalitywise I don't see anything missing... and will try it out in the coming week.

An upgrade step would be necessary to migrate existing field values which would be also on my list.

I think that would be the most future proof way to do it.

@agitator
Copy link
Member

Looked into using z3c.relationfield but gave up when I saw the to me weird seeming interface dependencies between core and widget, especially IContactContent... still think it would make sense.

Meanwhile started further upgrading/degroking the widget in https://github.com/collective/collective.contact.widget/blob/plone5-mockup-degrok

@agitator
Copy link
Member

agitator commented Mar 3, 2020

https://github.com/collective/collective.contact.core/tree/plone5-only seems to work on py3 now
also added py3 branches for plone.formwidget.masterselect and plone.formwidget.contenttree

robot is still haunting me an I'll probably give up on that - python test are green but will continue with manual testing

@agitator
Copy link
Member

agitator commented Feb 4, 2021

@sgeulette @gbastien any update on your plans towards Plone5/6 and a 2.0 version?

@sgeulette
Copy link
Member

Hi @agitator , we plan to start working on Plone5 migration at the end of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants