Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On persons listed on the directory view, display held_positions when hovering person title (tooltip). #53

Merged
merged 1 commit into from Aug 17, 2018

Conversation

gbastien
Copy link
Member

Hi @vincentfretin @frisi @sgeulette

I just added the "tooltip" class on the persons displayed on the directory view so it displays held positions.

For users not using collective.contact.facetednav, it is useful ;-)

Could you please review and merge?

Thank you!

Gauthier

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.161% when pulling 6467c27 on tooltip-person-directory into cbcf32b on master.

Copy link
Member

@sgeulette sgeulette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

@gbastien
Copy link
Member Author

gbastien commented Aug 2, 2018

Hi @frisi @vincentfretin ok for you? This only adds a tooptip class to the person displayed on the directory and displays held positions on hover, this is completely harmless.

Gauthier

@vincentfretin
Copy link
Member

sure why not

@gbastien
Copy link
Member Author

@vincentfretin thank you ;-)

@gbastien gbastien merged commit 3187c21 into master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants