Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easy to override the way sub organizations are displayed on an organization by calling a @@suborganizations view #56

Merged
merged 3 commits into from Aug 30, 2018

Conversation

gbastien
Copy link
Member

Hi @vincentfretin @sgeulette

I need to override the way sub organizations are displayed on an organization, and I prefer not override the entire organization.pt

I just replaced moved this part to a separated view "@@suborganizations" that is called in the organization view. By default rendering is same as before.

Thank you for reviewing and merging ;-)

Gauthier

@coveralls
Copy link

coveralls commented Aug 23, 2018

Coverage Status

Coverage decreased (-0.09%) to 70.073% when pulling 2b95c06 on suborgs-rendering-easy-override into 3187c21 on master.

@gbastien
Copy link
Member Author

Hi @vincentfretin

I do know if you received github review notification?

Can you review this? It does not change anything by default but make it easy to override.

Thank you!

Gauthier

@vincentfretin
Copy link
Member

Hi @gbastien, yes I received it, but didn't took the time to look at it.
If nobody else review it, merge it, same for the other PR pending. Really do whatever you want with this package, you can be one of the maintainers. I use it only on one project and I'll never upgrade it.

@gbastien gbastien merged commit 06f1623 into master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants