Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for identifiers token INameTokenTableRowSchema #75

Merged
merged 3 commits into from Jun 13, 2022
Merged

Added validation for identifiers token INameTokenTableRowSchema #75

merged 3 commits into from Jun 13, 2022

Conversation

odelaere
Copy link
Contributor

@odelaere odelaere commented Jun 7, 2022

No description provided.

@odelaere odelaere requested a review from gbastien June 7, 2022 10:23
@coveralls
Copy link

coveralls commented Jun 7, 2022 •
edited

Coverage Status

Coverage remained the same at 0.0% when pulling e7d5ddf on MOD-856_validate_identifiers into 0c26c05 on master.

gbastien
gbastien reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@gbastien gbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @odelaere

tu peux rebase çà va relancer les tests.

Ce serait bien d'ajouter un test, a priori créer un directory avec de mauvaises valeurs devrait provoquer une erreur...

Gauthier

@gbastien gbastien requested a review from sgeulette June 7, 2022 11:18
@sgeulette sgeulette merged commit 164d538 into master Jun 13, 2022
@sgeulette sgeulette deleted the MOD-856_validate_identifiers branch June 13, 2022 13:10
gbastien
gbastien approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@gbastien gbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbastien gbastien gbastien approved these changes

@sgeulette sgeulette Awaiting requested review from sgeulette

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@odelaere @coveralls @gbastien @sgeulette