Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about unfixed regression. #20

Closed
wants to merge 6 commits into from
Closed

Add note about unfixed regression. #20

wants to merge 6 commits into from

Conversation

ida
Copy link

@ida ida commented Jun 14, 2018

No description provided.

@ida
Copy link
Author

ida commented Jun 14, 2018

@fulv There are version-conflicts concerning the egg "six", so that's probably a Travis-config-bug?
Changing a README cannot do harm, would it be ok to merge anyway?
Seems to be the first commit since travis-checks were introduced, otherwise tests should have broken before, too. Thanks for your time.

@fulv
Copy link
Member

fulv commented Jun 14, 2018

Thanks, I will check and release this weekend.

@fulv
Copy link
Member

fulv commented Jun 18, 2018

Look what I found in https://dist.plone.org/release/5.1-latest/versions.cfg:

[versionannotations]
six =
    jenkins has failures with 1.11.0 - needs investigations.

So someone else already ran into this problem. Weird that it only affects 4.3 and 5.1, not 5.0.

@ida
Copy link
Author

ida commented Jun 18, 2018

Ok, so as written before: This package isn't broken, but the testing-machine and only the README was modified. Can you please make a release?

@fulv
Copy link
Member

fulv commented Jun 18, 2018

I understand that. But I tried and it does not let me merge your pull request, not even manually.

@ida
Copy link
Author

ida commented Jun 18, 2018

Oh, I see. As an owner can you commit the paragraph in the README directly to master? If owners cannot do that, would it possible to put off Jenkins, or the config that inhibits a merge, if tests fail?

@fulv
Copy link
Member

fulv commented Jun 18, 2018

I guess I'm not an owner of the github repository. I'm a maintainer on pypi, so I could make a release, but I can't check directly into master, nor merge a pull request that has broken tests.

@ida
Copy link
Author

ida commented Jun 18, 2018

Hm, do you know anyone in power to put off tests, or enable merging?
If this this is a travis-setup-bug, a lot of repos must be affected.
Don't think this is s.th. that could be fixed within this repo, what do you think?

@ida
Copy link
Author

ida commented Jun 18, 2018

Tried pinning six to 1.11.0, that'll let tests pass for Plone-4.3 only.

@fulv
Copy link
Member

fulv commented Jun 18, 2018 via email

@fulv
Copy link
Member

fulv commented Jun 19, 2018

Overridden by #21

@fulv fulv closed this Jun 19, 2018
@fulv fulv deleted the regressionInfo branch June 19, 2018 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants