Skip to content

Commit

Permalink
Merge cba7e22 into 3f3bbbd
Browse files Browse the repository at this point in the history
  • Loading branch information
hvelarde committed Aug 13, 2018
2 parents 3f3bbbd + cba7e22 commit 6ea1d4d
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 85 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Expand Up @@ -6,6 +6,9 @@ There's a frood who really knows where his towel is.
1.7b4 (unreleased)
^^^^^^^^^^^^^^^^^^

- Remove deprecated adapters ``CollectionUIDsProvider``, ``FolderUIDsProvider`` and ``GenericUIDsProvider``.
[hvelarde]

- Fix retrieval of available image scales in tile layout configuration for Plone 5 (fixes `#781 <https://github.com/collective/collective.cover/issues/781>`_).
[rodfersou]

Expand Down
14 changes: 0 additions & 14 deletions src/collective/cover/interfaces.py
Expand Up @@ -3,8 +3,6 @@
from zope.interface import Attribute
from zope.interface import Interface

import warnings


class ICoverLayer(Interface):
""" A layer specific for this add-on product.
Expand All @@ -31,18 +29,6 @@ def getSearchResults(self, filter_portal_types, rooted, document_base_url, searc
""" Returns the actual search results """


class ICoverUIDsProvider(Interface):
"""GenericUIDsProvider interface will be removed in collective.cover v1.7."""
warnings.warn(__doc__, DeprecationWarning)

def getUIDs(self):
"""Get UUIDs associated with the object.
could be the UUID of the object or a
list of related UUIDs.
@return: iterable of UUIDs
"""


class ITileEditForm(Interface):
"""Custom EditForm interface for a tile.
"""
Expand Down
30 changes: 0 additions & 30 deletions src/collective/cover/tiles/configure.zcml
Expand Up @@ -87,36 +87,6 @@
permission="zope.Public"
/>

<!--BEGIN DEPRECATED ADAPTERS. They will be removed on collective.cover 1.7.-->
<adapter
for="Products.ATContentTypes.interface.IATFolder"
provides="..interfaces.ICoverUIDsProvider"
factory=".list.FolderUIDsProvider"
/>

<!-- Archetypes-based collection -->
<adapter
zcml:condition="installed plone.app.collection"
for="plone.app.collection.interfaces.ICollection"
provides="..interfaces.ICoverUIDsProvider"
factory=".list.CollectionUIDsProvider"
/>

<!-- Dexterity-based collection -->
<adapter
zcml:condition="installed plone.app.contenttypes"
for="plone.app.contenttypes.interfaces.ICollection"
provides="..interfaces.ICoverUIDsProvider"
factory=".list.CollectionUIDsProvider"
/>

<adapter
for="*"
provides="..interfaces.ICoverUIDsProvider"
factory=".list.GenericUIDsProvider"
/>
<!--END DEPRECATED ADAPTERS. They will be removed on collective.cover 1.7.-->

<adapter
factory=".base.PersistentCoverTilePurgePaths"
name="collective.cover.tiles"
Expand Down
41 changes: 0 additions & 41 deletions src/collective/cover/tiles/list.py
Expand Up @@ -2,7 +2,6 @@
from AccessControl import Unauthorized
from collective.cover import _
from collective.cover.config import PROJECTNAME
from collective.cover.interfaces import ICoverUIDsProvider
from collective.cover.interfaces import ITileEditForm
from collective.cover.tiles.base import IPersistentCoverTile
from collective.cover.tiles.base import PersistentCoverTile
Expand All @@ -23,7 +22,6 @@

import logging
import six
import warnings


logger = logging.getLogger(PROJECTNAME)
Expand Down Expand Up @@ -373,42 +371,3 @@ def _get_title_tag(self, item):
@view.memoize
def get_title_tag(self, item):
return self._get_title_tag(item)


@implementer(ICoverUIDsProvider)
class CollectionUIDsProvider(object):
"""CollectionUIDsProvider adapter will be removed in collective.cover v1.7."""
warnings.warn(__doc__, DeprecationWarning)

def __init__(self, context):
self.context = context

def getUIDs(self):
"""Return a list of UUIDs of collection objects."""
return [i.UID for i in self.context.queryCatalog()]


@implementer(ICoverUIDsProvider)
class FolderUIDsProvider(object):
"""FolderUIDsProvider adapter will be removed in collective.cover v1.7."""
warnings.warn(__doc__, DeprecationWarning)

def __init__(self, context):
self.context = context

def getUIDs(self):
"""Return a list of UUIDs of collection objects."""
return [i.UID for i in self.context.getFolderContents()]


@implementer(ICoverUIDsProvider)
class GenericUIDsProvider(object):
"""GenericUIDsProvider adapter will be removed in collective.cover v1.7."""
warnings.warn(__doc__, DeprecationWarning)

def __init__(self, context):
self.context = context

def getUIDs(self):
"""Return a list of UUIDs of collection objects."""
return [IUUID(self.context)]

0 comments on commit 6ea1d4d

Please sign in to comment.