URI validation happens outside modal window

[hvelarde]

Entering an invalid URI on a Banner or Basic tile results on validation outside the edit tile modal.

[hvelarde]

This seems to be an issue with the custom edit form; I have no idea how to fix it.

Using a constraint is not an option as its code is never reached.

[idgserpro]

All validations have this problem. Don't know if using a constraint would even solve it, since using a validator in an adapter factory implementation using validator.WidgetValidatorDiscriminators gives the same problem.

The problem really is worse than validation being outside modal: if you click save after fixing the errors, then you're redirected to the tile view itself, with absolute no layout rendering.

[idgserpro]

This seems to be an issue with the custom edit form; I have no idea how to fix it.

Doing a raise Exception('EXCEPTION') right after this line:

collective.cover/src/collective/cover/tiles/edit.py

Line 51 in bc57f93

self.status = self.formErrorsMessage

Keeps the modal opened. Don't know if there' s a "propagation" method or approach that would raise the validations but still in the modal window.

[Mubra]

hi @idgserpro and @hvelarde , I was going through the issues and I think I have an idea to close this, HTML5 handles RegExp validators, I think this can be used to validate the form without closing the modal

[idgserpro]

@Mubra validation has to be server side. And we can have more complex validations than patterns.

[hvelarde]

I like @Mubra idea: it can easily catch 80% of errors without having to wait for server side validation; the only issue is the implementation has to be done upstream on z3c.form