Issue 641 - Use pat-modal instead of prepOverlay for Plone 5 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodfersou
changed the title
| // TODO: This does not solves, if we have more of a textarea widget in tiles. What's the solution? | ||
| var iframes = jQuery('#edit_tile iframe'); | ||
| var mcs = {}; | ||
| if ($.fn.prepOverlay !== undefined) { |
There was a problem hiding this comment.
I just reindent the code inside the if statement
hvelarde
force-pushed
the
issue_641
branch
2 times, most recently
from
d70fe4b
to
db4eee2
Compare
|
@rodfersou we'll need to create an upgrade step before the release to address this. |
|
@hvelarde I think this PR was not ready |
|
what was missing? |
|
I was going to check when there is p.a.widgets and prepOverlay. Also I suspect that tile rich text configuration will not work with this implementation. |
|
you can do that as part of #667. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #641