Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple CSS class selection in tile configuration for tiles diff… #780

Merged
merged 1 commit into from
Apr 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGES.rst
Expand Up @@ -6,7 +6,8 @@ There's a frood who really knows where his towel is.
1.7b2 (unreleased)
^^^^^^^^^^^^^^^^^^

- Nothing changed yet.
- Fix multiple CSS class selection in tile configuration for tiles different from basic tile.
[rodfersou]


1.7b1 (2018-04-27)
Expand Down
2 changes: 1 addition & 1 deletion src/collective/cover/profiles/default/metadata.xml
@@ -1,6 +1,6 @@
<?xml version="1.0"?>
<metadata>
<version>20</version>
<version>21</version>
<dependencies>
<dependency>profile-collective.js.galleria:default</dependency>
<dependency>profile-collective.js.jqueryui:default</dependency>
Expand Down
2 changes: 1 addition & 1 deletion src/collective/cover/static/js/layout_edit.js
Expand Up @@ -604,7 +604,7 @@
success: function(data) {
$('#tile-configure').html(data);
// Make sure CSS field is in first place
var css_id = 'formfield-collective-cover-basic-css_class';
var css_id = $('[id$=css_class]').attr('id');
var first = $('#configure_tile div.field:first');
if (first.attr('id') != css_id) {
$('#' + css_id).insertBefore(first);
Expand Down
11 changes: 11 additions & 0 deletions src/collective/cover/tests/test_upgrades.py
Expand Up @@ -706,3 +706,14 @@ def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self._how_many_upgrades_to_do(), 1)


class Upgrade20to21TestCase(UpgradeTestCaseBase):

def setUp(self):
UpgradeTestCaseBase.setUp(self, u'20', u'21')

def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self._how_many_upgrades_to_do(), 1)
1 change: 1 addition & 0 deletions src/collective/cover/upgrades/configure.zcml
Expand Up @@ -10,5 +10,6 @@
<include package=".v18" />
<include package=".v19" />
<include package=".v20" />
<include package=".v21" />

</configure>
1 change: 1 addition & 0 deletions src/collective/cover/upgrades/v21/__init__.py
@@ -0,0 +1 @@
# -*- coding: utf-8 -*-
20 changes: 20 additions & 0 deletions src/collective/cover/upgrades/v21/configure.zcml
@@ -0,0 +1,20 @@
<configure
xmlns="http://namespaces.zope.org/zope"
xmlns:genericsetup="http://namespaces.zope.org/genericsetup"
xmlns:i18n="http://namespaces.zope.org/i18n"
i18n_domain="collective.cover">

<genericsetup:upgradeSteps
source="20"
destination="21"
profile="collective.cover:default">

<genericsetup:upgradeStep
title="Cook JS resources"
description="There were changes in the JS files, so we need to cook the resources."
handler="..cook_javascript_resources"
/>

</genericsetup:upgradeSteps>

</configure>