Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix robot tests #874

Merged
merged 3 commits into from Oct 23, 2019
Merged

Fix robot tests #874

merged 3 commits into from Oct 23, 2019

Conversation

idgserpro
Copy link
Member

Don't override ZOPE_URL and PLONE_URL variables. Now plone.app.robotframework define ZOPE_PORT dynamically. Isn't possible change the port.

This avoids the error:

[ ERROR ] Error in file
'/home/travis/build/collective/collective.cover/src/collective/cover/tests/test_embed_tile.robot':
Getting keyword names from library 'Remote' failed: Calling dynamic
method 'get_keyword_names' failed: Connecting remote server at
http://localhost:55001/plone/RobotRemote failed: [Errno 111] Connection refused

This error started to occur after Plone version 4.3.19.

Don't override ZOPE_URL and PLONE_URL variables. Now
plone.app.robotframework define ZOPE_PORT dynamically. Isn't possible
change the port.

This avoids the error:

[ ERROR ] Error in file
'/home/travis/build/collective/collective.cover/src/collective/cover/tests/test_embed_tile.robot':
Getting keyword names from library 'Remote' failed: Calling dynamic
method 'get_keyword_names' failed: Connecting remote server at
http://localhost:55001/plone/RobotRemote failed: [Errno 111] Connection
refused

This error started to occur after Plone version 4.3.19.
Override the plone.app.robotframework 'Log in' keyword. The original
keyword
doesn't work in Plone 4.3. See:
plone/plone.app.robotframework#107
@idgserpro
Copy link
Member Author

@Mubra FYI.

Copy link
Member

@hvelarde hvelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvelarde hvelarde merged commit 316a982 into master Oct 23, 2019
@hvelarde hvelarde deleted the fix_tests branch October 23, 2019 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants