load count.js from disqus.com over https #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsahli
changed the title
hvelarde
requested changes
Sep 19, 2018
| @@ -22,7 +22,7 @@ def get_counter_js(self): | |||
|
|
|||
| if short_name: | |||
| result = """ | |||
| <script type="text/javascript" async="async" src="http://{0}.disqus.com/count.js"> | |||
| <script type="text/javascript" async="async" src="https://{0}.disqus.com/count.js"> | |||
There was a problem hiding this comment.
HTML5 specification urges authors to omit the attribute rather than provide a redundant MIME type; do you mind to remove the type attribute also? instead we can use:
<script async src="https://{0}.disqus.com/count.js">https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script
|
Thank you @hvelarde for the immediate review. Your requested changes are done. |
|
let me fix the Travis builds first. |
hvelarde
approved these changes
Sep 20, 2018
|
@philipsahli please update your branch so we can merge it. |
|
Travis build worked, Codacy Job still in state "Pending". Thank you in advance for the release and the great package! |
|
I made a new release for you: https://pypi.org/project/collective.disqus/2.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34