Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EasyForm lacks an uninstall profile #36

Closed
prakharjoshi opened this issue Jul 16, 2016 · 8 comments
Closed

EasyForm lacks an uninstall profile #36

prakharjoshi opened this issue Jul 16, 2016 · 8 comments

Comments

@prakharjoshi
Copy link
Member

I added a controlpanel config for easyforms and I can see the config icon for easyform in controlpanel but when I uninstall the add on still the config icon for easyform is still there but it should not be there, right ?

Here is the part of code that implemented the config icon for control panel https://github.com/collective/collective.easyform/blob/add-controlpanel-config-for-easyforms/collective/easyform/profiles/default/controlpanel.xml . This is just a basic implementation of the config. I will improve that but my question is that it should be removed when the the add-on is uninstalled. I have tried that in incognito too so its not because of cached data. I will like to know if I am doing it right or not ?

@davilima6
Copy link
Contributor

EasyForm currently lacks an uninstall profile. That's basic a copy of all files in profiles/default to profiles/uninstall, changing their contents to include remove="True". See http://docs.plone.org/develop/addons/components/genericsetup.html#uninstall-profile

@davilima6 davilima6 changed the title Config Icon for controlpanel is not removed when add-on is uninstalled EasyForm lacks an uninstall profile Jul 16, 2016
@prakharjoshi
Copy link
Member Author

Thanks for pointing that out. I will create uninstall profile too.

@tomgross
Copy link
Member

Hi @prakhar the easiest way to create an uninstall profile is to create a
package skeleton with bobtemplates.plone and copy over the relevant parts
to the original product.
prakhar notifications@github.com schrieb am Sa., 16. Juli 2016 um 13:27:

Thanks for pointing that out. I will create uninstall profile too.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAUtuD2RPzWhkcXL7L6QgkDyNnv40rvhks5qWMAJgaJpZM4JN-ut
.

@prakharjoshi
Copy link
Member Author

@tomgross @davilima6 Here are the changes for uninstalling the profile ae4354a . I followed the kewl blog and also the way suggested by Tom to create uninstall profile similar to bobtemplate.plone but its now working as of now. Correct me if I am going wrong at some place.

@davilima6
Copy link
Contributor

davilima6 commented Jul 19, 2016

@prakharjoshi You got almost everything right. I left a few comments where fixes are required.

@prakharjoshi
Copy link
Member Author

prakharjoshi commented Jul 19, 2016

@davilima6 @pbauer Thanks for suggestions. It worked finally !! 95bc191

@prakharjoshi
Copy link
Member Author

prakharjoshi commented Oct 12, 2016

I guess uninstall profile is there in master. Changes are merged we can close this issue. Ideas ? @pbauer @davilima6 @tomgross

@tomgross
Copy link
Member

@prakharjoshi Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants