Fix action urls and tests. #247
Conversation
When I try the original in a real browser, I get a click on *all* a-tags within the actions menu. This means that several popup windows appear. Clicking only the immediately contained a-tag means only the menu is opened. I hope this fixes #244
We will use this in actions.xml.
| name="object" | ||
| > | ||
| <object meta_type="CMF Action" | ||
| name="easyform-view" |
There was a problem hiding this comment.
This will add a 'puzzle piece' icon to the toolbar. Can you please add these three lines to easyform.css?
.icon-easyform-view.toolbar-menu-icon::before {
content: '\e807';
}
I don't think an upgrade step is necessary, but am not sure. When I locally start a test site with this change the easyform.css is bundled into the default.css automatically. But maybe we should upgrade the timestamp in the IBundleRegistry GS for this resource ....
There was a problem hiding this comment.
You added the css.
When running in bin/instance console, I do not see a result of your changes, so an upgrade step is needed. But that is trickier than it should be.
I will merge now, and worry about an upgrade step afterwards.
This is a follow-up on #247 (comment)
|
I have released this in |
See issue #219, issue #244, PR #239.
Includes upgrade step to apply the
actions.xml.Note that this adds a View link in the toolbar when you are within the Fields or Actions views, but it is at a different position than normally, because the normal position is only available for real content items.
The order is: Contents, Actions, View (followed by History and Sharing)