In columns.AbbrColumn, make sure there is no ' in tag title or it…

… is not rendered correctly in the browser, #MPMPHAI-41
collective · Sep 13, 2019 · 2bb366e · 2bb366e
1 parent 26700e4
commit 2bb366e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -5,8 +5,9 @@ Changelog
 2.7 (unreleased)
 ----------------
 
-- Nothing changed yet.
-
+- In `columns.AbbrColumn`, make sure there is no `'` in tag title or it is not
+  rendered correctly in the browser.
+  [gbastien]
 
 2.6 (2019-09-12)
 ----------------

diff --git a/src/collective/eeafaceted/z3ctable/columns.py b/src/collective/eeafaceted/z3ctable/columns.py
@@ -431,8 +431,10 @@ def renderCell(self, item):
         res = []
         for v in value:
             try:
+                tag_title = self._cached_full_vocab_instance.getTerm(v).title
+                tag_title = tag_title.replace("'", "&#39;")
                 res.append(u"<abbr title='{0}'>{1}</abbr>".format(
-                    safe_unicode(self._cached_full_vocab_instance.getTerm(v).title),
+                    safe_unicode(tag_title),
                     safe_unicode(self._cached_acronym_vocab_instance.getTerm(v).title)))
             except LookupError:
                 # in case an element is not in the vocabulary, add the value