Enforce Plone 5.2/Python 3 compatibility #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
hvelarde/plone52
branch
from
996ccb1
to
c6b6161
Compare
This acquisition wrapper manually wraps an instance of an object, but tests seems to be overkill and the method seems to be removed from Zope 4.
|
@jensens can you take a look on this? there's a small encoding issue with one test but in general I think the package must be compatible with Plone 5.2 and Python 3. |
jensens
requested changes
Apr 10, 2019
|
@jensens any idea on how to solve it? |
|
@hvelarde I think I fixed it. Merge if green? |
jensens
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs. #97