Removed optimization in utils.validateFileIsPDF to avoid multiple v…

…alidation because it breaks validation of several elements added in the same `REQUEST` (when using rest api for example).

See #SUP-36258

CHANGES.rst

@@ -9,6 +9,10 @@ Changelog
   [gbastien]
 - Corrected typo in french translation of `Preview`.
   [gbastien]
+- Removed optimization in `utils.validateFileIsPDF` to avoid multiple validation
+  because it breaks validation of several elements added in the same `REQUEST`
+  (when using rest api for example).
+  [gbastien]
 
 0.66 (2024-02-27)
 -----------------

src/collective/iconifiedcategory/tests/test_behaviors.py

@@ -286,20 +286,14 @@ def test_only_pdf_invariant(self):
         view = self.portal.restrictedTraverse('folder_contents')
         request['PUBLISHED'] = view
         self.assertFalse(invariants.validate(data))
-        # already_validateFileIsPDF was set in REQUEST
-        self.assertTrue(request.get('already_validateFileIsPDF'))
-        self.assertFalse(invariants.validate(data))
         # PDF needed
-        request.set('already_validateFileIsPDF', False)
         category.only_pdf = True
         errors = invariants.validate(data)
-        request.set('already_validateFileIsPDF', False)
         self.assertEqual(errors[0].message, u'You must select a PDF file!')
         request.form['form.widgets.file'].headers['content-type'] = 'application/pdf'
         # no file in request
         request.form = {}
         self.assertFalse(invariants.validate(data))
-        request.set('already_validateFileIsPDF', False)
         # editing a stored element
         category.only_pdf = False
         obj = api.content.create(
@@ -311,11 +305,9 @@ def test_only_pdf_invariant(self):
         view = obj.restrictedTraverse('view')
         request['PUBLISHED'] = view
         self.assertFalse(invariants.validate(data))
-        request.set('already_validateFileIsPDF', False)
         # PDF needed
         category.only_pdf = True
         errors = invariants.validate(data)
-        request.set('already_validateFileIsPDF', False)
         self.assertEqual(errors[0].message, u'You must select a PDF file!')
         obj.file = self.file_pdf
         self.assertFalse(invariants.validate(data))

src/collective/iconifiedcategory/utils.py

@@ -510,10 +510,6 @@ def _get_content_type(data):
 
     # check if file contentType is PDF only if used content_category requires it
     request = getRequest()
-    # avoid double validation
-    if request.get('already_validateFileIsPDF', False):
-        return
-    request.set('already_validateFileIsPDF', True)
     context = data.__context__ or request.get('PUBLISHED').context
     contentType = _get_content_type(data)
     if contentType is not None and contentType != 'application/pdf':