Updated upgrade step to 2103 (`Add 'last_updated' to categorized_elem…

…ents`), do not stop in case we found a `last_updated` key in `categorized_elements` of an element but continue to next element, maybe some elements were updated by another part of code.

CHANGES.rst

@@ -4,8 +4,11 @@ Changelog
 0.51 (unreleased)
 -----------------
 
-- Nothing changed yet.
-
+- Updated upgrade step to 2103 (`Add 'last_updated' to categorized_elements`),
+  do not stop in case we found a `last_updated` key in `categorized_elements`
+  of an element but continue to next element, maybe some elements were updated
+  by another part of code.
+  [gbastien]
 
 0.50 (2022-01-03)
 -----------------

src/collective/iconifiedcategory/upgrades.py

@@ -130,7 +130,7 @@ def upgrade_to_2103(context):
     '''The element "last_updated" is now in categorized_elements.'''
     catalog = api.portal.get_tool('portal_catalog')
 
-    # compute "modified" for categorized elements
+    # compute "last_updated" for categorized elements
     brains = catalog(
         object_provides='collective.iconifiedcategory.'
         'behaviors.iconifiedcategorization.IIconifiedCategorizationMarker')
@@ -148,8 +148,7 @@ def upgrade_to_2103(context):
         modified._timezone_naive = True
         if 'last_updated' in parent.categorized_elements[obj.UID()]:
             # already upgraded
-            pghandler.info('STOPPING, already migrated...')
-            break
+            continue
         parent.categorized_elements[obj.UID()]['last_updated'] = modified.asdatetime()
         parent._p_changed = True
     pghandler.finish()

src/collective/iconifiedcategory/upgrades.zcml

@@ -30,7 +30,7 @@
         profile="collective.iconifiedcategory:default" />
 
     <genericsetup:upgradeStep
-        title="Add 'modified' to categorized_elements"
+        title="Add 'last_updated' to categorized_elements"
         description=""
         source="2102"
         destination="2103"