UX Fixes #74
Merged
UX Fixes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 364
💛 - Coveralls |
datakurre
reviewed
Aug 10, 2018
| @@ -47,6 +47,8 @@ class IIftttTriggerAction(Interface): | |||
| u'Give the name of IFTTT event which you want to trigger' | |||
| ), | |||
| required=True, | |||
| # BUG - add one word contraint to this and to all ifttt_triggers | |||
| # constraints=validate_ifttt_event, | |||
There was a problem hiding this comment.
@Shriyanshagro Folloe https://docs.plone.org/develop/addons/schema-driven-forms/customising-form-behaviour/validation.html#constraints to add "constaint" to schema
constraint is a function that receives value to checked as its only argument (it knows nothing about the context of the value)
if values is ok it returs nothing
if value is not ok, it raises exception (see the exception class from the linked doc)
|
@Shriyanshagro I removed SelectWidget from this branch into #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr includes major UX fixes