Skip to content

Commit

Permalink
test fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
thet committed Jan 16, 2018
1 parent 0fd6141 commit 2cf171f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 11 deletions.
7 changes: 4 additions & 3 deletions src/collective/lazysizes/tests/test_setup.py
Expand Up @@ -10,8 +10,9 @@


JS = (
'++resource++collective.lazysizes/ls.twitter.min.js',
'++resource++collective.lazysizes/lazysizes-umd.min.js',
'++resource++collective.lazysizes/lazysizes/plugins/twitter/ls.twitter.min.js',
'++resource++collective.lazysizes/lazysizes/lazysizes-umd.min.js',
'++resource++collective.lazysizes/lazysizes/plugins/print/ls.print.min.js',
)


Expand Down Expand Up @@ -48,7 +49,7 @@ def test_version(self):
profile = 'collective.lazysizes:default'
setup_tool = self.portal['portal_setup']
self.assertEqual(
setup_tool.getLastVersionForProfile(profile), (u'9',))
setup_tool.getLastVersionForProfile(profile), (u'10',))


class UninstallTestCase(unittest.TestCase):
Expand Down
27 changes: 19 additions & 8 deletions src/collective/lazysizes/tests/test_upgrades.py
Expand Up @@ -47,7 +47,7 @@ def setUp(self):

def test_upgrade_to_2_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 2)

def test_add_new_field_to_configlet(self):
Expand Down Expand Up @@ -82,7 +82,7 @@ def setUp(self):

def test_upgrade_to_2_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 1)


Expand All @@ -93,7 +93,7 @@ def setUp(self):

def test_upgrade_to_2_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 2)

@unittest.skipIf(IS_PLONE_5, 'No easy way to test this under Plone 5')
Expand Down Expand Up @@ -128,7 +128,7 @@ def setUp(self):

def test_upgrade_to_2_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 2)

@unittest.skipIf(IS_PLONE_5, 'Upgrade step not supported under Plone 5')
Expand Down Expand Up @@ -158,7 +158,7 @@ def setUp(self):

def test_upgrade_to_6_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 1)


Expand All @@ -169,7 +169,7 @@ def setUp(self):

def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 2)

@unittest.skipIf(IS_PLONE_5, 'Upgrade step not supported under Plone 5')
Expand Down Expand Up @@ -197,7 +197,7 @@ def setUp(self):

def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 1)

def test_add_new_field_to_configlet(self):
Expand Down Expand Up @@ -232,5 +232,16 @@ def setUp(self):

def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(version, self.to_version)
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 1)


class To10TestCase(UpgradeTestCaseBase):

def setUp(self):
UpgradeTestCaseBase.setUp(self, u'9', u'10')

def test_registrations(self):
version = self.setup.getLastVersionForProfile(self.profile_id)[0]
self.assertGreaterEqual(int(version), int(self.to_version))
self.assertEqual(self.total_steps, 3)

0 comments on commit 2cf171f

Please sign in to comment.