Merge pull request #37 from collective/codeanalysis

Fix codeanalysis issues
collective · Mar 1, 2017 · efb2d97 · efb2d97
2 parents 384cbc3 + 081c691
commit efb2d97
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 1 deletion.
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,8 @@ cache:
   directories:
   - eggs
   - parts/node
+addons:
+  firefox: latest-esr
 env:
 - PLONE_VERSION=4.3
 - PLONE_VERSION=5.0
@@ -27,5 +29,10 @@ after_success:
 - bin/createcoverage -t "--layer=!Robot"
 - pip install coveralls
 - coveralls
+after_script:
+# Firefox complains: GConf-WARNING **: Got Disconnected from DBus.
+# And then it keeps hanging, causing a failed job after 30-50 minutes.
+# So we just kill Firefox.
+- pkill -9 firefox
 notifications:
   irc: irc.freenode.org#plone-testing
diff --git a/src/collective/liveblog/__init__.py b/src/collective/liveblog/__init__.py
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
 from zope.i18nmessageid import MessageFactory
 
+
 _ = MessageFactory('collective.liveblog')
diff --git a/src/collective/liveblog/testing.py b/src/collective/liveblog/testing.py
@@ -10,7 +10,6 @@
 from plone.app.testing import PloneSandboxLayer
 from plone.testing import z2
 
-
 import pkg_resources
 
 

diff --git a/src/collective/liveblog/tests/test_setup.py b/src/collective/liveblog/tests/test_setup.py
@@ -7,6 +7,7 @@
 
 import unittest
 
+
 CSS = '++resource++collective.liveblog/styles.css'
 
 ADD_PERMISSIONS = (